Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screenshare on wayland and style #1739

Merged
merged 2 commits into from
May 4, 2024

Conversation

SpecialAro
Copy link
Member

@SpecialAro SpecialAro commented May 3, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Fix screenshare on wayland and style component

Motivation and Context

If a user uses wayland it prompts the user twice for selecting a window (one from the native selector from the OS, and another for selecting the single available screen - after the native selection - on Ferdium). This PR removes the second prompt (the only prompt controlled by Ferdium) and instantly retrieves the only available source in the source array.

In this PR I also added some styling and fixes (so that the user sees a loading screen after pressing the screenshare feature - while he waits for the background communication between the main process and render process on getting the available streaming sources.

Tested on:

  • MacOS Sonoma
  • Windows 11
  • Fedora 40 (Wayland)

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

Fixes the double prompt on screenshare when using Wayland (Linux)

@SpecialAro SpecialAro requested a review from a team May 3, 2024 23:46
@SpecialAro SpecialAro self-assigned this May 3, 2024
@SpecialAro SpecialAro merged commit 87721c9 into ferdium:develop May 4, 2024
5 checks passed
@SpecialAro SpecialAro deleted the fix-screenshare-2 branch May 4, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant