Tested PR

fenos · Oct 16, 2015 · 8ea6ba0 · 8ea6ba0
1 parent eb8e3d8
commit 8ea6ba0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/spec/Fenos/Notifynder/Parsers/NotifynderParserSpec.php b/spec/Fenos/Notifynder/Parsers/NotifynderParserSpec.php
@@ -102,4 +102,26 @@ function it_will_throw_exception_when_strict_extra_is_enabled()
         $this->shouldThrow(ExtraParamsException::class)
             ->during('parse',[$notification]);
     }
+
+    /** @test */
+    function it_will_parse_4_extra_params()
+    {
+        $extra = [
+            'name' => 'fabri',
+            'username' => 'fenos',
+            'status' => 'active',
+            'prof' => 'dev'
+        ];
+
+        $text = 'Hi {extra.name}, your username is: {extra.username} your status: {extra.status} your profession: {extra.prof}';
+        $notification = [
+            'body' => [
+                'text' => $text
+            ],
+            'extra' => json_encode($extra)
+        ];
+
+        $parsedText = "Hi {$extra['name']}, your username is: {$extra['username']} your status: {$extra['status']} your profession: {$extra['prof']}";
+        $this->parse($notification)->shouldReturn($parsedText);
+    }
 }
diff --git a/src/Notifynder/Parsers/NotifynderParser.php b/src/Notifynder/Parsers/NotifynderParser.php
@@ -106,9 +106,8 @@ protected function categorizeSpecialValues($specialValues)
      */
     protected function replaceExtraValues($extrasToReplace, $extra, $body)
     {
-        // replace the values specified in the extra
-
-        // Whichever type i
+        // I'll try my best to have returned the
+        // extra param as an array
         $extra = $this->extraToArray($extra);
 
         // wildcard