Improved data retrieval in GitHubData class #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once GitHubThread is initiated, a new thread is started - responsible for checking if cache is valid.
Locks are used to handle the two threads, http call starts running asap after cache thread has finished. Http thread maintains cache property set by the owner - no http connection calls if cache is last modified within the last 10 days.
In case http thread runs before cache thread, http thread checks if cache thread is alive - if yes, http thread waits until cache thread successfully finished.
This should solve the loading lag if the cause was making http requests.
Let me know how it goes for you.