Skip to content

Commit

Permalink
Do not compile RocksDB 6.0.2 with VS > 15
Browse files Browse the repository at this point in the history
RocksDB 6.0.2 had an invalid use of const, which was later fixed in facebook/rocksdb#6048 Applying the fix as a patch to 6.0.2 could result in a regression, so just don't compile with this compiler instead
  • Loading branch information
fennibay committed Jun 22, 2021
1 parent ff45efe commit dfd9814
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions recipes/rocksdb/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ def configure(self):
self.settings.compiler == "Visual Studio" and \
tools.Version(self.settings.compiler.version) < "15":
raise ConanInvalidConfiguration("Rocksdb requires Visual Studio 15 or later.")

if self.version == "6.0.2" and \
self.settings.os == "Windows" and \
self.settings.compiler == "Visual Studio" and \
tools.Version(self.settings.compiler.version) > "15":
raise ConanInvalidConfiguration("Rocksdb 6.0.2 is not compilable with Visual Studio >15.") # See https://github.com/facebook/rocksdb/issues/6048

if self.settings.build_type == "Debug":
self.options.use_rtti = True # Rtti are used in asserts for debug mode...
Expand Down

0 comments on commit dfd9814

Please sign in to comment.