Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Chrome: Long press on .cropper-container triggers unexpected behavior #1155

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

VinceCYLiao
Copy link
Contributor

Summary
On iOS Chrome, after long-pressing on the cropper container area which makes the context menu pop up, only the pan gesture can be recognized, and other gestures don't work. And the pan gesture now only scales the image instead of moving it like it was. You can see it in the video below.

RPReplay_Final1711422308.mov

Right now, the solution we found is adding "-webkit-touch-callout: none;" to the ".cropper-container" class selector.

If you'd like to apply this change, please review my pull request and merge it if there are no problems. Thanks!
What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@fengyuanchen fengyuanchen merged commit a444f6f into fengyuanchen:main Apr 21, 2024
This was referenced Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants