Add macOS CI jobs #310
Merged
Add macOS CI jobs #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightlark
requested review from
e-n-f,
migurski,
arredond,
dnomadb and
ChrisLoer
as code owners
e-n-f
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as the Linux CI jobs, but macOS -- something to help make sure that changes are actually portable and don't break builds or tests on macOS.
The macOS release build configuration is pretty fast (in my initial run, it finished a minute before the Ubuntu release build), though the debug build on macOS was quite a bit slower (~2 minutes longer than the Ubuntu debug build).
If desired, the workflow triggers could be changed to only run the jobs for PRs and commits to main to keep the number of jobs on each commit to a minimum.