Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for LineStringZM #160

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Add support for LineStringZM #160

merged 6 commits into from
Oct 23, 2023

Conversation

versilov
Copy link
Contributor

No description provided.

s3cur3
s3cur3 suggested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@s3cur3 s3cur3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @versilov! I don't object to shipping this, but first we'll need to add %Geo.LineStringZM{} to the upstream geo package. (I've pushed a test that demonstrates the failure.)

@versilov
Copy link
Contributor Author

versilov commented Oct 2, 2023

we'll need to add %Geo.LineStringZM{} to the upstream geo package.

Here it is: https://github.com/kanatohodets/geo/tree/btyler/line_string_zm

@s3cur3
Copy link
Contributor

s3cur3 commented Oct 3, 2023

Oh! 🤦‍♂️ Sorry, I didn't realize the PR already existed. I'm gonna try to wrap my head around the changes in that PR and see if I can't get it merged this week.

@s3cur3 s3cur3 mentioned this pull request Oct 23, 2023
Merged
@s3cur3 s3cur3 self-assigned this Oct 23, 2023
s3cur3
s3cur3 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@s3cur3 s3cur3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the latest release of geo, it works and it's ready to ship! Thanks so much for your contribution here, @versilov!

@s3cur3 s3cur3 merged commit b09d20b into felt:master Oct 23, 2023
19 checks passed
@s3cur3
Copy link
Contributor

s3cur3 commented Mar 11, 2024

Released in v3.6.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3cur3 s3cur3 s3cur3 approved these changes

Assignees

@s3cur3 s3cur3

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@versilov @s3cur3