Use a custom string_to_float/1 function instead of plain String.to_float for ensure_numeric #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter doesn't work when the textual representation is an integer, Float.parse/1 however works with it but might have its own side effects that haven't been tested for (likely support for things like underscores and other elixir-esque formatting)
s3cur3
reviewed
Sep 23, 2024
lib/geo/utils.ex
Outdated
| end | ||
| end | ||
|
|
||
| @spec string_to_float(String.t()) :: float() |
There was a problem hiding this comment.
Suggested change
| @spec string_to_float(String.t()) :: float() | |
| @spec string_to_float!(String.t()) :: float() | no_return() |
There was a problem hiding this comment.
huh, TIL about no_return, I'll add the test shortly
IceDragon200
force-pushed
the
string-to-float
branch
from
c26aa45 to
dca8223
Compare
And a decode test to ensure it works as intended with integers EDIT: You know I should read properly next time EDIT.2: Made the formatter happy
IceDragon200
force-pushed
the
string-to-float
branch
from
dca8223 to
2befd05
Compare
|
Okay everything should be in order now |
s3cur3
approved these changes
Sep 23, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.to_float will not handle integer representations, instead Float.parse can be used, I almost wanted to roll something myself until I remembered Float.parse exists.
Related
#220