Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test #217

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix broken test #217

merged 1 commit into from
Sep 5, 2024

Conversation

s3cur3
Copy link
Contributor

@s3cur3 s3cur3 commented Aug 30, 2024

I merged a PR where I'd inadvertently broken the tests because it failed to run the tests at all, and the retry said there were no tests to run. 🤦‍♂️

Test plan

Open the test of the latest version of Elixir from CI; confirm the tests actually ran, rather than failing and passing the CI step anyway.

@s3cur3 s3cur3 enabled auto-merge (squash) August 30, 2024 22:24
@s3cur3 s3cur3 assigned kyleVsteger and unassigned axelson Sep 3, 2024
Copy link

@kyleVsteger kyleVsteger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious — how is this passing in other PRs passing now?

Edit — nvm I see this is a different repo

@s3cur3 s3cur3 merged commit 7f3077b into master Sep 5, 2024
21 checks passed
@s3cur3 s3cur3 deleted the ty/fix-test branch September 5, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants