Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read whole terminal frame at once to avoid console data append glitches #299

Merged
merged 2 commits into from
Apr 7, 2019
Merged

Read whole terminal frame at once to avoid console data append glitches #299

merged 2 commits into from
Apr 7, 2019

Conversation

maxhora
Copy link
Collaborator

@maxhora maxhora commented Apr 6, 2019

Fixes console output rendering issues that appear on whole buffer frame update (happens on usage of tmux, mosh).

More details:

  • Similar issues happen both for ConPTY and WinPTY on running tmux
  • Issue disappears if to increase output std reading buffer. But if to resize the terminal to exceed the buffer the issue come back again.
  • "Unexpected" characters appear between calls of _appServiceConnection.SendMessageAsync(CreateMessage(e));
    2019-04-07_1-30-41-console-message-issue

Changes in PR read output console stream for whole terminal buffer at once to execute _appServiceConnection.SendMessageAsync only single time per "frame".

@felixse felixse merged commit 39960dd into felixse:master Apr 7, 2019
@mjs mjs deleted the append-output-issue branch April 8, 2019 23:16
@jackluo923
Copy link

Is it only me that this merge introduced a bug where upon disconnecting from tmux, the tmux's "bar" at the bottom stays visible until the window is resized?

@maxhora
Copy link
Collaborator Author

maxhora commented Jun 5, 2019

@jackluo923 does it happen for you under WSL only? Seems under ssh or mosh the issue is not reproducible

@jackluo923
Copy link

jackluo923 commented Jun 5, 2019

@Maxris Thanks for making me aware there are "remote tabs" where we can use ssh or mosh directly. Previously, I have always started WSL in order to ssh and mosh into remote machines. It seems using mosh or ssh directly via FluentTerminal works flawlessly.

So to answer your question, yes this only happens under WSL. Thinking back, this bug could have been introduced by the computer upgrading itself to the latest Windows version during a period when switched to the version on the latest code master branch couple weeks ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants