Ap/ssh Implemented SSH by using the exsting infrastructure #293
Conversation
# Conflicts: # FluentTerminal.App/FluentTerminal.App.csproj
| return; | ||
| } | ||
|
|
||
| var profile = new ShellProfile |
There was a problem hiding this comment.
Eventually we probably want to define a dedicated RemoteProfile type but this will probably do for now
There was a problem hiding this comment.
Yes, that's just a temp solution for now. I think we will need to extend this once we allow to also store connections
| var profile = new ShellProfile | ||
| { | ||
| Arguments = $"-p {connectionInfo.Port:#####} {connectionInfo.Username}@{connectionInfo.Host}", | ||
| Location = @"C:\Windows\System32\OpenSSH\ssh.exe", |
There was a problem hiding this comment.
Do all versions of Windows which FluentTerminal supports include OpenSSH? If not, there should probably be some graceful handling of this (i.e. explain to the user why it doesn't work).
There was a problem hiding this comment.
Seems like openssh.exe was added in 1709, which is also our current minimum version
There was a problem hiding this comment.
OpenSSH is a "Windows Feature", and can be installed if already isn't. (The same as with WSL.) But yes, I agree that we should handle this! Will create an issue for this one.
I will also call Felix to review this PR, if he has time.