Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updpatch: electron{28,29,30,31,32} #4122

Merged
merged 1 commit into from
Sep 25, 2024
Merged

updpatch: electron{28,29,30,31,32} #4122

merged 1 commit into from
Sep 25, 2024

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Sep 23, 2024

@kxxt
updpatch: electron{28,29,30,31,32}
8bd5c14 
- Sync 'is_clang=true' to old electrons, to work around (possibly a
  regression in gnu ld) relocation truncated to fit.
- Force override electron version with pkgver to fix riscv-forks/electron-riscv-releases#4
  - This is because electron determines its version by finding the
    nearest git tag. But in riscv fork, the upstream tags are not synced
    back.
@kxxt kxxt marked this pull request as ready for review September 25, 2024 07:52
@kxxt
Copy link
Contributor Author

kxxt commented Sep 25, 2024

This PR is ready now.

@felixonmars felixonmars merged commit a01c09a into felixonmars:master Sep 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version file doesn't match in electron-vXX.X.X-linux-riscv64.zip
2 participants
@kxxt @felixonmars