add parent to module constructor

[oroce]

Pass parent module to module constructor.

Here a use case:

https://github.com/oroce/pin-clone/blob/master/app.js#L100-L103
https://github.com/oroce/pin-clone/blob/master/test/server/api.js#L24

[domenic]

Test please?

[oroce]

Damn you silly git add -u.
Im gonna commit as soon as i get back to my computer.

[oroce]

test attached.

[domenic]

What should exports.module.parent be? Are there any properties of it you can test?

[oroce]

currently module.parent is node-sandboxed-module. But it might should be the parent module of node-sandboxed-module?

[domenic]

Shouldn't it be the module that requires the module under test?

[oroce]

it is now.

[domenic]

I don't think I'm quite communicating clearly.

Let's say you have module A which requires module B.

Then you sandboxed-module require module A.

Inside module B, module.parent should be module A, just as if you had non-sandboxed-module-required module A.

From what I can tell of your patch, it makes module.parent for every module in the tree be simply sandboxed-module/lib/sandboxed_module's module.parent, instead of giving each their own specific module.parent depending on their place in the tree.

[oroce]

i see your point, but what is the use case.

sandbox-module won't load the tree, just loads the module which you required via SandboxedModule.require(<filename>).

It would be a use case, if sandboxed-module would require fake modules, but it doesn't.
Gist: https://gist.github.com/oroce/6474892

As you can see fake module's are required by test.js.

[domenic]

Ah, you are of course right! Thank you for having the patience to walk me through it. Merging momentarily, and will push a new release.

[domenic]

Merged as c3df0b5 with a slightly updated test; thanks!

[oroce]

cool, thx.