Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding padding to week (W) #156

Merged
merged 3 commits into from
Jan 23, 2021
Merged

Adding padding to week (W) #156

merged 3 commits into from
Jan 23, 2021

Conversation

smithalexk
Copy link
Contributor

Creating a WW option which adds padding to weeks for weeks < 10

Adding a WW option which pads week
@chase-manning
Copy link
Collaborator

@smithalexk Great idea!

Would you be able to please make a couple of inclusions in this PR?
Adding documentation for the WW mask to the Readme would be awesome!
And also if you could please add some tests to cover this 😄

@smithalexk
Copy link
Contributor Author

Hi @chase-manning yep will do! Sorry! I set this up quickly in a dependency of another extension, saw it worked, and decided to set up a PR for it. I'll get everything set up soon!

@smithalexk
Copy link
Contributor Author

Ok, the tests are added (and passing), and the README has been updated 😄

@chase-manning
Copy link
Collaborator

@smithalexk Awesome job! Thanks heaps for the contribution 😄
Merging now and will publish a package update.

@chase-manning chase-manning merged commit 71ec7d8 into felixge:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants