Skip to content

Commit

Permalink
Create a unit test to reproduce the repr issue
Browse files Browse the repository at this point in the history
- a post fake secret
- added to fake api
- create a unit test

Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com>
  • Loading branch information
feliperuhland committed Feb 19, 2020
1 parent a9867c9 commit 8b5a34a
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
9 changes: 9 additions & 0 deletions tests/unit/fake_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
FAKE_PATH = '/path'
FAKE_VOLUME_NAME = 'perfectcherryblossom'
FAKE_NODE_ID = '24ifsmvkjbyhk'
FAKE_SECRET_ID = 'epdyrw4tsi03xy3deu8g8ly6o'

# Each method is prefixed with HTTP method (get, post...)
# for clarity and readability
Expand Down Expand Up @@ -511,6 +512,12 @@ def post_fake_network_disconnect():
return 200, None


def post_fake_secret():
status_code = 200
response = {'Id': FAKE_SECRET_ID}
return status_code, response


# Maps real api url to fake response callback
prefix = 'http+docker://localhost'
if constants.IS_WINDOWS_PLATFORM:
Expand Down Expand Up @@ -642,4 +649,6 @@ def post_fake_network_disconnect():
CURRENT_VERSION, prefix, FAKE_NETWORK_ID
), 'POST'):
post_fake_network_disconnect,
'{1}/{0}/secrets/create'.format(CURRENT_VERSION, prefix):
post_fake_secret,
}
1 change: 1 addition & 0 deletions tests/unit/fake_api_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def make_fake_api_client(overrides=None):
fake_api.post_fake_create_container()[1],
'create_host_config.side_effect': api_client.create_host_config,
'create_network.return_value': fake_api.post_fake_network()[1],
'create_secret.return_value': fake_api.post_fake_secret()[1],
'exec_create.return_value': fake_api.post_fake_exec_create()[1],
'exec_start.return_value': fake_api.post_fake_exec_start()[1],
'images.return_value': fake_api.get_fake_images()[1],
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/models_secrets_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import unittest

from .fake_api_client import make_fake_client
from .fake_api import FAKE_SECRET_ID


class CreateServiceTest(unittest.TestCase):
def test_secrets_repr(self):
client = make_fake_client()
secret = client.secrets.create(name="test", data="secret")
assert secret.__repr__() == "<Secret: '{}'>".format(FAKE_SECRET_ID)

0 comments on commit 8b5a34a

Please sign in to comment.