Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify toString logic #140

Merged
merged 2 commits into from
Oct 14, 2023
Merged

refactor: simplify toString logic #140

merged 2 commits into from
Oct 14, 2023

Conversation

Amir-P
Copy link
Contributor

@Amir-P Amir-P commented May 25, 2022 •
edited
Loading

Status

READY

Breaking Changes

NO

Description

The goal is to simplify toString method on Equatable and EquatableMixin and remove repetitive logic.

@Amir-P Amir-P requested a review from felangel as a code owner May 25, 2022 13:02
@Amir-P
Copy link
Contributor Author

Amir-P commented Jun 2, 2022

@felangel Will you be able to check this PR?

felangel
felangel approved these changes Oct 14, 2023
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@felangel felangel changed the title Simplified toString refactor: simplify toString logic Oct 14, 2023
@felangel felangel merged commit 49e92fa into felangel:master Oct 14, 2023
2 of 3 checks passed
@Amir-P Amir-P deleted the patch-1 branch October 15, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@Amir-P Amir-P

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amir-P @felangel