Accessibility improvements #99
Conversation
#Added - Accessibility improvement: use of roles and other wai-aria attributes - Accessibility improvement: focus management when baguetteBox popup is open References and acknowledgments in code
| &:focus { | ||
| background-color: rgba(50,50,50,.9); | ||
| } | ||
|
|
||
| &:hover { |
There was a problem hiding this comment.
This could be placed in one statement like so:
&:focus,
&:hover {
...
}
|
Thanks for your contribution! Looks great, now I need some time to review it. |
| overlayStatus = true; | ||
| lastFocus = document.activeElement; | ||
| // change focus to next button if more than one image. Otherwise, focus on close button | ||
| if ( 1 < imagesElements.length ) { |
There was a problem hiding this comment.
Can you remove the spaces inside the brackets following the current style?
There was a problem hiding this comment.
And move the check to the right.
accessibility improvements revised, following notes by feimosi
|
Not sure i understood properly all notes, but... anyway, there's a new commit following the suggestions and requests. Hope this works now. PS: This is my first public contribution and I am using Github desktop. Forgive any mistakes made by this noob. :-) |
|
The branch seems messed up to be honest. Just check the diff. |
|
@feimosi: you want me to cherry pick this and fix it? |
|
I think we should wait for @2aces to clean this up. |
|
I doubt he can, that is why I offered ;) |
feimosi
changed the title
|
Ok, let's wait a day or two, then feel free to do it yourself :) |
|
@feimosi sorry for the mistakes. In order do avoid further mistakes, what would you advise me to do with it?
|
git fetch upstream
git rebase -i upstream/master
# properly rebase your branch |
|
Sorry, @feimosi @XhmikosR I am facing a serious health problem on my shoulder and could not address the issues on my code and my bad commit. It will take a few weeks of therapy for me getting back to code. Therefore: 1 - I welcome anyone cherry-picking it |
|
All right, I'll try to cherry pick this, clean it up and make a new PR. |
|
@2aces sure, I understand and no problem. Get well soon! |
Added
open
References and acknowledgments in code
Closes #98