Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add passive mode support for touch events #148

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

feimosi
Copy link
Owner

@feimosi feimosi commented Mar 11, 2017

Resolves #142

Still needs some testing on mobile devices.

@XhmikosR
Copy link
Contributor

@feimosi: Is there anything left for this to get merged?

@feimosi
Copy link
Owner Author

feimosi commented Sep 15, 2017

Sorry for my late reply. Not all browsers support the options argument to the addEventListener. I need to test it first so nothing breaks.

@XhmikosR
Copy link
Contributor

@feimosi: if you still want to support IE8, then addEventListener won't work there at all. You will need to use attachEvent instead.

@feimosi
Copy link
Owner Author

feimosi commented Sep 16, 2017

I've got attachEvent fallback in the bind method already.
The problem with options is, even Edge doesn't support it, so it may treat the object as a truthy value for useCapture. I need to add feature detection code, but it'll increase the size of the script.

@feimosi feimosi force-pushed the passive-events-support branch 4 times, most recently from c7c2bd4 to 1b1454e Compare January 23, 2018 13:10
@feimosi feimosi merged commit 0e5c464 into dev Jan 23, 2018
@feimosi feimosi deleted the passive-events-support branch January 23, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants