Better title cutting #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, why would negating [A-Za-z0-9] not work? |
|
I guess that would come down to a matter of preference. I like the way it looks when it cuts at the end of a sentence (emojis are often used in place of a period). Depending on how its implemented you could be cutting after commas, dashes, parenthesis, etc. And maybe that's fine, just not how I personally preferred it. You would also have to account for accented characters |
|
LGTM, un-draft it and I'll bump the beta up to stable and make this the new beta |
|
working great on adderbot, will merge and bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would super love to not use the emojis library but it seems like emojis don't really have a single block in unicode.
Ofc we could just include a static list of emojis or reference an external list