Improve handling of wikiDomains and Allowed parameters #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paul90
commented
Sep 18, 2016
paul90
commented
- make wikiDomains and Allowed really optional
- add warning if neither wikiDomains or Allowed are configured
- add warning if using default security module (read-only)
* make wikiDomains and Allowed really optional * add warning if neither wikiDomains or Allowed are configured * add warning if using default security module (read-only)
|
Part of a solution to #87, here we make the use of wikiDomains and allowed parameters truly optional. |
| @@ -25,9 +25,9 @@ module.exports = exports = (argv) -> | |||
| runningServers = [] | |||
|
|
|||
| if argv.allowed | |||
| allowedHosts = argv.allowed.split(',') | |||
| allowedHosts = _.split(argv.allowed, ',') | |||
There was a problem hiding this comment.
Just curious. Why the move away from native split?
There was a problem hiding this comment.
The code was crashing, with the trace pointing to it as the problem.
|
Thanks for this. We are accumulating special cases but these seem necessary. The log notices are a welcome addition. |
|
Published as + wiki@0.10.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.