Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: For each test function, create an isolated project directory #20

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Tests: For each test function, create an isolated project directory #20

merged 4 commits into from
Oct 23, 2019

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented Oct 21, 2019

This allows concurrent test execution.

Fixes #11

@hroncok
Copy link
Member Author

hroncok commented Oct 21, 2019

This works with xdist and detox. tox --parallel doesn't: tox-dev/tox#1444

torsava
torsava reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@torsava torsava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks sane, though I don't feel confident in fully understanding the implications.

encukou
encukou approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nitpick:

tests/test_integration.py Outdated Show resolved Hide resolved
@hroncok hroncok merged commit 688a41c into fedora-python:master Oct 23, 2019
@hroncok hroncok deleted the fixtures branch October 23, 2019 16:02
@hroncok
Copy link
Member Author

hroncok commented Oct 23, 2019

@torsava @encukou Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torsava torsava torsava left review comments

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow paralel test execution of integration tests
3 participants
@hroncok @encukou @torsava