additional valgrind suppression for Python 3.9 #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That suppression looks really broad. I’m concerned that we may actually have noticed a real memory leak in Python 3. |
vstinner
approved these changes
Mar 28, 2020
There was a problem hiding this comment.
LGTM.
It's likely the infamous GIL lock which is created and not freed at exit. Sadly, Python cannot destroy the GIL since daemon threads can be blocked on waiting for the GIL. It's a hard problem.
More generally, if some allocations are not released explicitly at exit, it's fine since Py_InitializeFromConfig() is only called once ;-)
|
By the way, if you are curious: here is an article telling the rationale for not deleting the GIL at exit ;-) https://vstinner.github.io/daemon-threads-python-finalization-python32.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BZ#1817665