Add modulemd-validator man page #445
Conversation
Drop the `with_py{23}_overrides` options to meson and add `with_py2`
in its place. `with_py2` will now default to `false`, since python2
is now EOL.
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
mmathesius
force-pushed
the
validator-man-page
branch
from
281900d to
3d519ce
Compare
|
@sgallagher Thanks for the feedback. I'll take care of that and sort through any missing dependencies shortly. One other thing that came to mind regarding the spec file... Should the man page be moved into the main package alongside with the |
Oh, I completely missed that. Yes, the manpage belongs with the executable. |
mmathesius
force-pushed
the
validator-man-page
branch
2 times, most recently
from
be8599e to
049ba37
Compare
|
There was an error while creating SRPM. You can re-trigger build by adding a comment ( Output: |
mmathesius
force-pushed
the
validator-man-page
branch
from
049ba37 to
29c99ec
Compare
The original ones only supported Python 3 on Fedora 31. We were experiencing additional issues with python3 on Rawhide as well as python2 on all releases. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Python on OpenSUSE Tumbleweed seems broken; valgrind detects a lot of use-after-free issues. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Reconcile differences between upstream and Fedora/EPEL packaging. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Signed-off-by: Merlin Mathesius <mmathesi@redhat.com>
mmathesius
force-pushed
the
validator-man-page
branch
from
29c99ec to
8da8ae1
Compare
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Add modulemd-validator man page
| '--no-info', | ||
| '--section=1', | ||
| ] | ||
| custom_target( |
There was a problem hiding this comment.
I think this target needs to be under the with_manpages condition, as it can't be generated when help2man is not found.
There was a problem hiding this comment.
from meson.build
with_manpages = get_option('with_manpages')
help2man = find_program('help2man', required: with_manpages)
This means that if with_manpages is set to enabled, the meson configure step will fail with an error (since the program is required) if help2man cannot be located. If with_manpages is auto (the default), it means that it will be built if help2man happens to be available, but if it's not, the help2man variable will be a disabler() object. A disabler() object means that any target that requires it will simply be skipped. If with_manpages is disabled, a disabler() object is always returned.
There was a problem hiding this comment.
Thanks.
But I'm not sure if that's quite right. Don't you need to write find_program('help2man', required: with_manpages, disabler: true) to get a disabler object?
In any event, this doesn't appear to be currently working as you expect: see https://travis-ci.org/jon-turney/meson-corpus-test/jobs/648623888.
Is this a meson regression (i.e. you've seen this work as expected for some meson version?). A bug? Or a problem with the meson documentation?
Resolves #365.
I'm not sure if the packaging of the generated man page will work. I also suspect CI will blow up with missing dependencies for non-Fedora distributions.