converted from g_test_add() to g_test_add_func() #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgallagher
requested changes
Jan 8, 2020
|
I did run |
sgallagher
reviewed
Jan 9, 2020
modulemd/tests/test-dirty.py
Outdated
| @@ -11,6 +11,7 @@ | |||
| # For more information on the license, see COPYING. | |||
| # For more information on free software, see | |||
| # <https://www.gnu.org/philosophy/free-sw.en.html>. | |||
| #comment | |||
There was a problem hiding this comment.
What is the point of this?
There was a problem hiding this comment.
I just removed it, I will be pushing it after the tests complete.
fixed errors fixed errors in functions solved comment issue
|
I have been running |
sgallagher
added a commit
that referenced
this pull request
Jan 23, 2020
converted from g_test_add() to g_test_add_func() Resolves: #417 Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrected the previous syntax and also modified the required functions to enable compatibility with g_test_add_func()