-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected result of koji_util.get_srpm_arches #246
Comments
I think either is fine. I'd personally prefer to canonicalize the arch (it seems easier) |
mizdebsk
added a commit
that referenced
this issue
Mar 5, 2018
mizdebsk
added a commit
that referenced
this issue
Mar 5, 2018
msimacek
pushed a commit
that referenced
this issue
Mar 5, 2018
msimacek
pushed a commit
that referenced
this issue
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When build_arches parameter of koji_util.get_srpm_arches (or corresponding config variable) contains non-canonical arch, get_srpm_arches silently skips that arch.
Reproducer:
Expected output:
{'aarch64', 'armv7hl', 'i686', 'ppc64', 'ppc64le', 's390x', 'x86_64'}
Actual output:
{'aarch64', 'ppc64', 'ppc64le', 's390x', 'x86_64'}
Proposed solution 1: make get_srpm_arches raise an exception if non-canonical arch is passed in build_arches
Alternative solution 2: make get_srpm_arches map build_arches to canonical arches
@msimacek Which solution is better in your opinion?
The text was updated successfully, but these errors were encountered: