Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle huge single message email notifications #288

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

jeremycline
Copy link
Member

fedmsg_meta does some insane things in its msg2long_form[0]. Add a guard
to make sure any crazy msg2long_form implementation can't produce a
multi-{MB,GB,TB...ZB} message.

Signed-off-by: Jeremy Cline jeremy@jcline.org

@codecov
Copy link

codecov bot commented Mar 27, 2018

Codecov Report

Merging #288 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #288      +/-   ##
===========================================
+ Coverage    56.95%   56.98%   +0.02%     
===========================================
  Files           70       70              
  Lines         3722     3724       +2     
  Branches       477      478       +1     
===========================================
+ Hits          2120     2122       +2     
  Misses        1536     1536              
  Partials        66       66
Impacted Files Coverage Δ
fmn/formatters.py 82.14% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce97e44...ef8dca5. Read the comment docs.

fedmsg_meta does some insane things in its msg2long_form[0]. Add a guard
to make sure any crazy msg2long_form implementation can't produce a
multi-{MB,GB,TB...ZB} message.

[0] fedora-infra/fedmsg_meta_fedora_infrastructure#464

Signed-off-by: Jeremy Cline <jeremy@jcline.org>
@jeremycline jeremycline merged commit ef8dca5 into fedora-infra:develop Apr 2, 2018
@jeremycline jeremycline deleted the huge-single-emails branch April 2, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants