Add an alembic revision adding to CI notifs to the packager's defaut pack #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #225 +/- ##
========================================
Coverage 44.42% 44.42%
========================================
Files 70 70
Lines 3881 3881
Branches 496 496
========================================
Hits 1724 1724
Misses 2098 2098
Partials 59 59Continue to review full report at Codecov.
|
pypingou
changed the title
jeremycline
reviewed
Aug 17, 2017
| continue | ||
|
|
||
| modified += 1 | ||
| filt.add_rule(session, valid_paths, path, negated=True) |
There was a problem hiding this comment.
Are you sure negated=True is correct? Is the purpose of this migration to ignore all messages matched by ci_step_complete that have to do with a user's packages?
There was a problem hiding this comment.
To ignore the ones that have successfully completed, ie: notify about the ones that did not (that failed)
jeremycline
reviewed
Aug 17, 2017
| target = "Events on packages that I own" | ||
|
|
||
|
|
||
| def upgrade(): |
There was a problem hiding this comment.
Please add a comment detailing the purpose of the migration
pypingou
force-pushed
the
default_ci_notifs
branch
from
425456d
to
d73ee2a
Compare
… pack This setting will notify packager of any step of the CI pipeline that did not complete successfully. Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
pypingou
force-pushed
the
default_ci_notifs
branch
from
d73ee2a
to
3abc010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting will notify packager of any step of the CI pipeline that
did not complete successfully.
Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr