-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start adding CI related rules #221
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #221 +/- ##
===========================================
- Coverage 44.89% 44.42% -0.48%
===========================================
Files 69 70 +1
Lines 3840 3881 +41
Branches 495 496 +1
===========================================
Hits 1724 1724
- Misses 2057 2098 +41
Partials 59 59
Continue to review full report at Codecov.
|
fmn/rules/ci.py
Outdated
""" All CI events | ||
|
||
Adding this rule will indiscriminately match notifications of all types | ||
from `ci <https://admin.fedoraproject.org/pkgdb>`_, i.e. new build queued, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL looks... wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same url appears elsewhere in the module. Maybe use https://fedoraproject.org/wiki/FedoraAtomicCI/pipeline ?
You may always want to replace the vague "ci" with the more specific "the Fedora Atomic CI pipeline".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't sure what would be a good URL to use, the wiki page? the actual jenkins instance?
Maybe the wiki page is better since the jenkins instance will be linked to in the messages.
Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr