Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding CI related rules #221

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Start adding CI related rules #221

merged 1 commit into from
Aug 15, 2017

Conversation

pypingou
Copy link
Member

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

@codecov
Copy link

codecov bot commented Aug 10, 2017

Codecov Report

Merging #221 into develop will decrease coverage by 0.47%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #221      +/-   ##
===========================================
- Coverage    44.89%   44.42%   -0.48%     
===========================================
  Files           69       70       +1     
  Lines         3840     3881      +41     
  Branches       495      496       +1     
===========================================
  Hits          1724     1724              
- Misses        2057     2098      +41     
  Partials        59       59
Impacted Files Coverage Δ
fmn/rules/ci.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e157251...a6a1fdc. Read the comment docs.

fmn/rules/ci.py Outdated
""" All CI events

Adding this rule will indiscriminately match notifications of all types
from `ci <https://admin.fedoraproject.org/pkgdb>`_, i.e. new build queued,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL looks... wrong.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same url appears elsewhere in the module. Maybe use https://fedoraproject.org/wiki/FedoraAtomicCI/pipeline ?

You may always want to replace the vague "ci" with the more specific "the Fedora Atomic CI pipeline".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't sure what would be a good URL to use, the wiki page? the actual jenkins instance?

Maybe the wiki page is better since the jenkins instance will be linked to in the messages.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>
Copy link
Member

@jeremycline jeremycline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeremycline jeremycline merged commit ef41d9b into develop Aug 15, 2017
@jeremycline jeremycline deleted the ci branch August 15, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants