Update the preference format for example messages #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the format of preferences handed to the ``fmn.lib.recipients`` API. Unfortunately there are no tests with this change. The web application has 0% test coverage and needs to be refactored. I've filed an issue to track this[0]. [0] fedora-infra#219 Fixes fedora-infra#210 Signed-off-by: Jeremy Cline <jeremy@jcline.org>
Codecov Report
@@ Coverage Diff @@
## develop #220 +/- ##
========================================
Coverage 44.89% 44.89%
========================================
Files 69 69
Lines 3840 3840
Branches 495 495
========================================
Hits 1724 1724
Misses 2057 2057
Partials 59 59
Continue to review full report at Codecov.
|
|
Ah, did the preferences format change in some previous PR but was missed in this corner? Assuming so. 👍 |
|
Yes, there were two separate preference loading functions and two separate formats (one was a list, another a dict) so I merged them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the format of preferences handed to the
fmn.lib.recipientsAPI. Unfortunately there are no tests with thischange. The web application has 0% test coverage and needs to be
refactored. I've filed an issue to track this[0].
[0] #219
Fixes #210
Signed-off-by: Jeremy Cline jeremy@jcline.org