Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the topic the FMN consumer subscribes to configurable #218

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

jeremycline
Copy link
Member

Allow the user to configure what topic(s) the FMN consumer subscribes
to. The default remains "everything".

Fixes #216

Signed-off-by: Jeremy Cline jeremy@jcline.org

Allow the user to configure what topic(s) the FMN consumer subscribes
to. The default remains "everything".

Fixes fedora-infra#216

Signed-off-by: Jeremy Cline <jeremy@jcline.org>
@codecov-io
Copy link

Codecov Report

Merging #218 into develop will increase coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #218      +/-   ##
===========================================
+ Coverage    44.53%   44.89%   +0.36%     
===========================================
  Files           69       69              
  Lines         3840     3840              
  Branches       495      495              
===========================================
+ Hits          1710     1724      +14     
+ Misses        2072     2057      -15     
- Partials        58       59       +1
Impacted Files Coverage Δ
fmn/consumer/consumer.py 32% <100%> (+12%) ⬆️
fmn/lib/models.py 63.74% <0%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8165b04...5e63845. Read the comment docs.

@pypingou
Copy link
Member

pypingou commented Aug 8, 2017

Cool 👍 for me thanks!

@jeremycline jeremycline merged commit e157251 into fedora-infra:develop Aug 8, 2017
@jeremycline jeremycline deleted the configurable-topics branch August 8, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants