This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Send image raw_url to fedmsg instead of the build_name #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me, do we expect this change to have an impact? |
|
Not really but it would show the proper data. Also since I will be updating this change to fedmsg.meta |
|
Cool 👍 for me then |
|
Thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the image_url passed to fedmsg is not an url rather the value same as that of image_name.
https://apps.fedoraproject.org/datagrepper/id?id=2016-805a2138-956b-470f-a24b-85d22af8b10f