This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
services.ec2: Migrate fedimg to support to longer resource ids #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cverna
approved these changes
May 24, 2018
| @@ -179,7 +179,7 @@ def _create_volume(self, source): | |||
| _log.debug('Initiate task to upload the image via S3. ' | |||
| 'Fetching task id...') | |||
|
|
|||
| task_id = get_item_from_regex(output, regex='\s(import-vol-\w{8})') | |||
| task_id = get_item_from_regex(output, regex='\s(import-vol-\w{17})') | |||
There was a problem hiding this comment.
It would be nice to maybe add a test for this function.
There was a problem hiding this comment.
It seems that it is failing flake8 too.
fedimg/services/ec2/ec2imguploader.py:182:80: E501 line too long (80 > 79 characters)
task_id = get_item_from_regex(output, regex='\s(import-vol-\w{17})')```
sayanchowdhury
force-pushed
the
migrate-to-longer-resource-ids
branch
from
50a6849 to
8701836
Compare
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
sayanchowdhury
force-pushed
the
migrate-to-longer-resource-ids
branch
from
8701836 to
7d9b74d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sayan Chowdhury sayan.chowdhury2012@gmail.com