Feature/formattable operations #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the change in rule.py could use a little comment but that' not a blocker, so 👍 |
ralphbean
added a commit
that referenced
this pull request
Feb 14, 2014
Feature/formattable operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually already hotpatched and running on the badges-backend01 node. It is needed for this badge: https://badges.fedoraproject.org/badge/what-goes-around-comes-around-karma-i
The trick is for line 33 here:
https://git.fedorahosted.org/cgit/badges.git/tree/rules/packager-karma-01.yml#n33
without this code, you cannot do the
"%(msg.comment.update_submitter)s"substitution there.