Separate critpath and non-critpath min_karma settings #5802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamWill
force-pushed
the
separate-min-karma
branch
from
78b9b6f to
fafaee6
Compare
mattiaverga
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Do you think adding release.min_karma and release.critpath_min_karma to the Release's __include_extras_ would be worthwhile? (so that those settings are exposed in the json representation of Release). And, maybe, the (,critpath).mandatory_days_in testing too.
Not sure how many tests would fail by adding these, but I think it could be useful to have those settings exposed for "debugging" purpose.
|
Hmm, maybe, but it feels like a separate PR to me? wdyt? |
FESCo has decided to reinstate different minimum karma for critpath and non-critpath: https://pagure.io/fesco/issue/3289 so we need to support this. This introduces critpath.min_karma, and makes min_karma work much like mandatory_days_in_testing, with the appropriate value for each update worked out at the level of the update based on whether it's critpath or not. We leave the default value of min_karma at 2 even though 1 would be closer to the policy now, just because the tests were written around 2 and are hard to adjust, especially the test_autopush_reached tests in test_updates.py. We'll set it to 1 in downstream config. Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
force-pushed
the
separate-min-karma
branch
from
fafaee6 to
3ca3e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FESCo has decided to reinstate different minimum karma for critpath and non-critpath:
https://pagure.io/fesco/issue/3289
so we need to support this. This introduces critpath.min_karma, and makes min_karma work much like mandatory_days_in_testing, with the appropriate value for each update worked out at the level of the update based on whether it's critpath or not.
We leave the default value of min_karma at 2 even though 1 would be closer to the policy now, just because the tests were written around 2 and are hard to adjust, especially the
test_autopush_reached tests in test_updates.py. We'll set it to 1 in downstream config.