Validate side-tag update as regular one if the submitter is not side-tag creator #5764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tag creator Signed-off-by: Nikola Forró <nforro@redhat.com>
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
mattiaverga
approved these changes
Oct 20, 2024
|
Thanks! |
|
@nforro thank you so much!! ETA on deployment? |
Probably a couple of weeks after the end of infrastructure freeze |
|
This is now deployed in prod ;-) |
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this change is to allow a user who has commit rights to all builds in an update to edit the update, even though the creator of the update and of the associated side-tag is a different user.
Users have been able to edit/waive test failures on regular updates created by Packit provided they had commit access to all the builds. This doesn't work with side-tag updates, where Packit is the creator of the side-tag. I don't see a reason why the validation couldn't allow both, the sidetag creator and the maintainer of all packages, to make changes.