Do not reify releases list in pyramid request #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaverga
added
8.0-backports
mattiaverga
force-pushed
the
cached-releases
branch
from
0cc54aa to
958126a
Compare
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
mattiaverga
force-pushed
the
cached-releases
branch
from
958126a to
3e6281b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Release.all_releases()method is already cached and set to be refreshed whenever a Release changes state. However, by having thereleasesrequest property reified makes that property never refreshed, thus is causing the releases list web page never updated with current changes until the server is restarted.