Remove Vagrant development environment (and a couple of small related fixes) #5600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes all traces (I hope) of the Vagrant development environment, as discussed in fedora-infra#5565 (comment) . I preserved the VS Code docs in a very half-assed way as it seemed nicer than just deleting them, but I hope somebody who actually uses VS Code can test it out and improve those. Signed-off-by: Adam Williamson <awilliam@redhat.com>
While working on removing Vagrant I noticed this didn't work, so let's fix it. It runs into the same shebang issue I had problems with for a couple of other things, and it turns out to be easiest to just forget about the 'normal' implementation and replace it with a simple alias, since we know where the config file is in the development environment. Signed-off-by: Adam Williamson <awilliam@redhat.com>
We really aren't. Signed-off-by: Adam Williamson <awilliam@redhat.com>
mattiaverga
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all traces (I hope) of the Vagrant development environment, as discussed in #5565 (comment) . I preserved the VS Code docs in a very half-assed way as it seemed nicer than just deleting them, but I hope somebody who actually uses VS Code can test it out and improve those.
It also fixes
bodhi-shellin the BCD env, and updates the docs to not claim we still use Jenkins for CI.