Have the authentication policy honor config settings #5572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaverga
force-pushed
the
fix-auth
branch
from
b0b3900 to
7819392
Compare
|
Ideally this should also include a test, right? I believe there was a test before #5288 , which 5288 removed. |
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
mattiaverga
force-pushed
the
fix-auth
branch
from
7819392 to
687e3ac
Compare
|
Re added tests |
|
LGTM. |
|
Cool, I'll merge this in the 8.0 and push a 8.0.1 out since this is really an urgent bug. |
|
I guess it's a good thing I got completely lost in the auth flow trying to get logout / login to work in the dev env! In the end I couldn't even get that to work so I had to hack in a workaround, but at least I found this, heh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.