Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuring OIDC storage path #4603

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

TomasTomecek
Copy link
Contributor

I understand the default makes sense for desktop users. For us in Packit, our
~/.config is not writable in our deployment as k8s mounts secrets there R/O
so we cannot create new files in ~/.config (but $HOME is fine!).

Thanks to this PR, we'd get rid of this nasty hack in our codebase:
packit/packit@57cf094

Copy link
Contributor

@mattiaverga mattiaverga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of failures due to flake8 style checks, the Integration Tests failures should go away once you rebase to latest devel.
It would also nice to add a release note as described here.

@TomasTomecek TomasTomecek force-pushed the configurable-oidc-storage branch from 211ba90 to d08749f Compare July 13, 2022 13:53
@TomasTomecek
Copy link
Contributor Author

This slipped b/w my fingers after I returned from my vacation.

fixed and rebased

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek TomasTomecek force-pushed the configurable-oidc-storage branch from d08749f to 957a0e6 Compare July 13, 2022 14:02
@TomasTomecek
Copy link
Contributor Author

TomasTomecek commented Jul 14, 2022

The rawhide failure is unrelated:

++ git rev-parse --short HEAD
fatal: detected dubious ownership in repository at '/bodhi'
To add an exception for this directory, call:
	git config --global --add safe.directory /bodhi

BTW we got bit by that too.

Copy link
Contributor

@mattiaverga mattiaverga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit bb16f37 into fedora-infra:develop Jul 14, 2022
@TomasTomecek TomasTomecek deleted the configurable-oidc-storage branch July 15, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants