Do not cache tags for archived and disabled releases

Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>

bodhi-server/bodhi/server/models.py

@@ -983,7 +983,8 @@ def get_tags(cls):
         data = {'candidate': [], 'testing': [], 'stable': [], 'override': [],
                 'pending_testing': [], 'pending_stable': []}
         tags = {}  # tag -> release lookup
-        for release in cls.query.all():
+        for release in cls.query.filter(cls.state.notin_([ReleaseState.archived,
+                                                          ReleaseState.disabled])).all():
             for key in data:
                 tag = getattr(release, f'{key}_tag')
                 data[key].append(tag)

bodhi-server/tests/services/test_updates.py

@@ -43,7 +43,6 @@
     Compose,
     Group,
     ModulePackage,
-    PackageManager,
     Release,
     ReleaseState,
     RpmBuild,
@@ -3693,21 +3692,7 @@ def test_edit_update_with_different_release(self, *args):
             r = self.app.post_json('/updates/', args)
 
         # Add another release and package
-        Release.get_tags.cache_clear()
-        release = Release(
-            name='F18', long_name='Fedora 18',
-            id_prefix='FEDORA', version='18',
-            dist_tag='f18', stable_tag='f18-updates',
-            testing_tag='f18-updates-testing',
-            candidate_tag='f18-updates-candidate',
-            pending_signing_tag='f18-updates-testing-signing',
-            pending_testing_tag='f18-updates-testing-pending',
-            pending_stable_tag='f18-updates-pending',
-            override_tag='f18-override',
-            branch='f18',
-            package_manager=PackageManager.unspecified,
-            testing_repository=None)
-        self.db.add(release)
+        self.create_release('18')
         pkg = RpmPackage(name='nethack')
         self.db.add(pkg)
         self.db.commit()
@@ -4642,21 +4627,7 @@ def test_list_updates_by_alias_and_updateid(self):
     def test_submitting_multi_release_updates(self, *args):
         """ https://github.com/fedora-infra/bodhi/issues/219 """
         # Add another release and package
-        Release.get_tags.cache_clear()
-        release = Release(
-            name='F18', long_name='Fedora 18',
-            id_prefix='FEDORA', version='18',
-            dist_tag='f18', stable_tag='f18-updates',
-            testing_tag='f18-updates-testing',
-            candidate_tag='f18-updates-candidate',
-            pending_signing_tag='f18-updates-testing-signing',
-            pending_testing_tag='f18-updates-testing-pending',
-            pending_stable_tag='f18-updates-pending',
-            override_tag='f18-override',
-            branch='f18',
-            package_manager=PackageManager.unspecified,
-            testing_repository=None)
-        self.db.add(release)
+        self.create_release('18')
         pkg = RpmPackage(name='nethack')
         self.db.add(pkg)
         self.db.commit()

news/PR5238.dev

@@ -0,0 +1 @@
+Use functools lru_cache for caching `Release.all_releases()` and `Release.get_tags()` instead of a custom implementation