Remove testing tag when an update is pushed stable

Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
fedora-infra · Nov 26, 2021 · 70e3c96 · 70e3c96
1 parent 32eba6d
commit 70e3c96
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/bodhi/server/tasks/approve_testing.py b/bodhi/server/tasks/approve_testing.py
@@ -159,6 +159,7 @@ def approve_update(update: Update, db: Session):
                 update.remove_tag(update.release.pending_testing_tag)
                 update.remove_tag(update.release.pending_stable_tag)
                 update.remove_tag(update.release.pending_signing_tag)
+                update.remove_tag(update.release.testing_tag)
                 update.remove_tag(update.release.candidate_tag)
 
     log.info(f'{update.alias} processed by approve_testing')
diff --git a/bodhi/tests/server/tasks/test_approve_testing.py b/bodhi/tests/server/tasks/test_approve_testing.py
@@ -686,7 +686,8 @@ def test_autotime_update_zero_day_in_testing_no_gated_gets_pushed_to_rawhide(
             # removes f17-updates-testing-pending and f17-updates-pending
             assert remove_tag.call_args_list == \
                 [call('f17-updates-testing-pending'), call('f17-updates-pending'),
-                 call('f17-updates-signing-pending'), call('f17-updates-candidate')]
+                 call('f17-updates-signing-pending'), call('f17-updates-testing'),
+                 call('f17-updates-candidate')]
 
             assert add_tag.call_args_list == \
                 [call('f17-updates')]