Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading of build info for modules. #235

Merged

Conversation

ckelleyRH
Copy link
Contributor

Modules don't have a buildId, they have mbsId.

Modules don't have a buildId, they have mbsId.
@ckelleyRH
Copy link
Contributor Author

ckelleyRH commented Feb 1, 2024

@Andrei-Stepanov - My local testing doesn't prove this will 100% fix the problem, but it certainly fixes the first-level problem.

Instead of the reported and reproduced 500 code, with this patch I instead got this error:

GraphQL error: URL not configured for the 'rh' MBS instance

I wasn't sure how/if to set that up, so I hardcoded the URL into the config and then I got this error:

GraphQL error: Error communicating with MBS: AxiosError: Request failed with status code 404

...which looks like a permissions issue.

So yeah, I can't say 100% this is the whole fix but it certainly is an improvement on what is there.

@Andrei-Stepanov
Copy link
Contributor

Looks good! @ckelleyRH thank you

@Andrei-Stepanov Andrei-Stepanov merged commit 03d1012 into fedora-ci:feature-opensearch Feb 1, 2024
1 check passed
@ckelleyRH ckelleyRH deleted the module_build_info branch February 1, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants