Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.dm: Update timely-dataflow link to the current repository. #752

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

davideagen
Copy link
Contributor

The originally linked repository hasn't been updated in 5 years and is a fork of the active repository, which is https://github.com/TimelyDataflow/timely-dataflow

The originally linked repository hasn't been updated in 5 years and is a fork of the active repository, which is https://github.com/TimelyDataflow/timely-dataflow
@benesch
Copy link
Collaborator

benesch commented Dec 13, 2024

Thanks!

@benesch benesch merged commit 1f2c49f into fede1024:master Dec 13, 2024
4 of 8 checks passed
@davideagen
Copy link
Contributor Author

Thanks for the quick response, but I just realized that it really should still link to the old repository. I didn't realize until after I made the PR that the kafkaesque subproject in the original repo linked from the blog post is not included in the active timely-dataflow repository.

So, I think my PR should be reverted.

@benesch
Copy link
Collaborator

benesch commented Dec 13, 2024

It was only removed earlier this year: TimelyDataflow/timely-dataflow#545

So one option would be to link to an older version of timely. The other option is just to strike the link entirely since it's no longer included in the latest version of timely.

@davideagen
Copy link
Contributor Author

Perhaps it is best to remove the link entirely, given that it was removed from the main timely repo. With both you and Frank at Materialize, according to your GitHub profiles, I'll let you two decide what's best. If you want to keep the links, I've created #753 to revert the change.

@benesch
Copy link
Collaborator

benesch commented Dec 15, 2024

Yeah, after consideration, let's just strike it from the README. I updated #753 to do so and merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants