Fix test directory in CI #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently Cargo moved test output into target/debug/deps at some point, but our test scripts were not updated accordingly.
This prevents CI from breaking when a dependency releases a new patch release that bumps its MSRV.
Various minor changes to how offsets work were made in v1.6.0, but went unnoticed because CI was broken. Adjust our tests accordingly.
This could only happen if the consumer was misconfigured (in the reported case, a missing group.id), but still not ideal. This commit fixes the bug by properly handling errors inside of Consumer::position. Fix #360.
benesch
added a commit
to kination/rust-rdkafka
that referenced
this pull request
Jun 30, 2021
Fix test directory in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Cargo moved test output into target/debug/deps
at some point, but our test scripts were not updated accordingly.