-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add producer transaction support #293
Conversation
Opened this PR following #289. |
@benesch any clue how to make the transaction methods |
Sorry, I've been swamped lately. About to head off on vacation, which means I should actually have a few spare hours to look at this. But I gave it a quick skim and everything looks very promising!
Nope, afraid not. Maybe there are some tricks along the lines mentioned in #273, but any solution along those lines wouldn't be plug n play. |
Even with the event interface, there seem to be no transaction events defined in librdkafka. |
While writing the tests I ran into something that I was able to reproduce using the go librdkafka wrapper and opened an issue. |
Sorry for the massive delay here. I'm working through this today one commit at a time. |
I am very new to Rust, but I would love to see exactly once semantics for Kafka. |
Co-authored-by: Robert Ignat <robert.ignat91@gmail.com> Closes fede1024#289. Closes fede1024#293.
Co-authored-by: Robert Ignat <robert.ignat91@gmail.com> Closes fede1024#289. Closes fede1024#293.
Thanks very much for this. This was an absolutely awesome PR. I'm sorry that my review stalled out on this for so long. I took this and made a few changes in #323. The only real substantive change was fixing a few memory safety issues with By the way, there's now a |
To do: