Improve ConsumerContext::commit_callback #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @scrogson, thanks very much for this! I’m actually quite relieved that this failed CI, as I spot a double free in your patch and it’s good to know that Valgrind is able to catch that. I think I know how to fix it, though, so I’ll send up a fix and hopefully get this merged when I get home this evening. |
benesch
force-pushed
the
commit_callback
branch
from
31268b9
to
5ecbb91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to remove exposing
*mut rdkafka_sys::RDKafkaTopicPartitionListinConsumerContext::commit_callbackand exposerdkafka::topic_partition_list::TopicPartitionListinstead.Should resolve #197