feature/1784 - Fix oidc callback redirect to go to login redirect as opposed to '/' which was previously redirecting to login #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which was previously redirecting to login
toddlees
requested changes
Dec 2, 2024
| @@ -33,8 +33,7 @@ def get_api_status(_request): | |||
| re_path(BASE_V1_URL, include("fecfiler.feedback.urls")), | |||
| re_path(BASE_V1_URL, include("fecfiler.oidc.urls")), | |||
| re_path(BASE_V1_URL, include("fecfiler.cash_on_hand.urls")), | |||
| re_path(r"", include("fecfiler.devops.urls")), | |||
| path("", RedirectView.as_view(url=LOGIN_REDIRECT_CLIENT_URL)), | |||
| path("", RedirectView.as_view(url="/api/docs/")), | |||
There was a problem hiding this comment.
We still need re_path(r"", include("fecfiler.devops.urls")),
There was a problem hiding this comment.
Fixed this and got it ordered so path("") call comes before re_path("") call to prevent authentication issue with "" route.
…t to allow usage without authentication
|
dheitzer
approved these changes
Dec 3, 2024
toddlees
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue FECFILE-1784