feature/1715 - report status failure on submit polling #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddlees
requested changes
Nov 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fecgov.atlassian.net/browse/FECFILE-1715
DEV note on the ticket was correct in that this was caused only when polling for status happened. We were getting the following fecfile error in the log which was causing it to get set to FAILURE:
fecfile-celery-worker | [error ] Error in polling: 'UploadSubmission' object has no attribute 'fec_batch_id' [fecfiler.web_services.tasks] _from_structlog=True _recorSolution was to add safe attribute access. Also needed to update some function signatures to take fec_batch_id as they were inconsistent with the interface. Added a unit test to test the function that was failing.