-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security response headers #3124
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3124 +/- ##
==========================================
Coverage ? 74.67%
==========================================
Files ? 120
Lines ? 7151
Branches ? 633
==========================================
Hits ? 5340
Misses ? 1811
Partials ? 0
Continue to review full report at Codecov.
|
c4968bb
to
b2accbf
Compare
b2accbf
to
6707353
Compare
6018542
to
01b8dd9
Compare
59d8e59
to
0ba47f0
Compare
c78ba9a
to
0ba47f0
Compare
3c7f258
to
2cbee26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I don't see any further errors for the CSP and the cache-control header is now coming through on the app level domain. This was tested on stage. Thanks for your work on this @lbeaufort!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work.
1)on local cms (point to local api) : play with some CSP directives, work as expected.
run curl command, see CSP and cache-control added.
2)on stage, test most pages. work fine.
3) run scan website “stage.fec.gov" and get A score. (before C)
Summary
Resolves #3069
report-uri
that sends violation reports to API for now (ran into csrf issues with a Django route)CSRF_TRUSTED_ORIGINS
setting to address csrf errorsImpacted areas of the application
List general components of the application that this PR will affect:
Screenshots
None, this is pure code
Related PRs
List related PRs against other branches:
How to test
Check each section of the site to make sure that the content security policy is not interfering with anything we're pulling into the site.
How to test the changes on stage
stage
with Circle (as of 8/28) (stage.fec.gov)