Fixes tests which fail when run in isolation #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests would fail with a null reference if they were run on their own:
It_returns_the_state_that_was_found_first_Example_1()
It_returns_the_state_that_was_found_first_Example_2()
It_returns_the_state_that_was_found_first_Example_3()
When_query_returns_false_It_raises_an_exception()
This is because
SessionConfiguration
is used early on in the tests, but it isn't initialised untilBuildSession()
is called later. When run in combination with other tests, they pass by chance, depending which other test has run before it, as in that case theSessionConfiguration
is then initialised by another test.I've added a
SetUp
method to ensure a freshSessionConfiguration
each test (it always uses a default one anyway). Alternatively we could swap around the order of the lines in these tests so thatvar session = BuildSession(....)
comes beforevar state1 = ....